JawZ:
Ah yes ofc. I need to do it as an if statement instead of a lerp... will try that! Thanks!
--JawZ-- ENB resources, updated 15 september-14
- Author
- Message
-
Offline
- *sensei*
- Posts: 373
- Joined: 07 Mar 2013, 10:14
-
Offline
- *blah-blah-blah maniac*
- Posts: 1938
- Joined: 05 Mar 2012, 02:08
Re: --JawZ-- ENB resources for Skyrim, updated 09/01
Yeah well that's one way to do it and as I said a fast and simple approach to it.
Also you don't need the TInteriorFactor, you can just simply use the default one EInteriorFactor if you want.
I just thought I would show the approach with adjustable factor value so that you can customize it to affect
either interior or exterior with the "0, 1" or "1, 0".
Also you don't need the TInteriorFactor, you can just simply use the default one EInteriorFactor if you want.
I just thought I would show the approach with adjustable factor value so that you can customize it to affect
either interior or exterior with the "0, 1" or "1, 0".
-
Offline
- *sensei*
- Posts: 373
- Joined: 07 Mar 2013, 10:14
Re: --JawZ-- ENB resources for Skyrim, updated 09/01
Really getting annoyed by these function calls now... I am missing some basic logic in the HLSL syntax here.
This works.
However this stops the code from working at all.
I have boiled the actual code down to this obviously, since the actual code would take up WAY too much space... hence why I use function calls to begin with. This is also the reason why I do not drop them entirely, since they would just clutter up the file way way too much. Also now I am just getting a bit annoyed that I do not know this, since I thought I had the basic syntax down.
If you want I can pm you the actual whole code... Its for my new approach to tonemapping. Originally I wanted to just keep one set of tonemapping parameters for everything, but now I would be interested in splitting them up.
edit: Added the missing ; as pointed out. I did have those included in the actual example
This works.
Code: Select all
--------------------------------------Outside Pixel shader----------------------------------------------
float A = 1.0;
float k = 1.0;
float3 TestFunc(float3 x)
{
float B = A;
return x * A
}
float3 LargeFunc(float3 color)
{
float3 numerator = TestFunc(color);
float3 denominator = TestFunc(k);
return numerator / denominator;
}
--------------------------------------Inside Pixel shader----------------------------------------------
color.xyz = LargeFunc(color.xyz);
Code: Select all
--------------------------------------Outside Pixel shader----------------------------------------------
float AExt = 1.0;
float kExt = 1.0;
float AInt = 1.0;
float kInt = 1.0;
float3 TestFunc(float3 x)
{
float B = A;
return x * A
}
float3 LargeFunc(float3 color)
{
float3 numerator = TestFunc(color);
float3 denominator = TestFunc(k);
return numerator / denominator;
}
--------------------------------------Inside Pixel shader----------------------------------------------
if(EinteriorFactor = 0.0)
{
float A = AExt;
float k = kExt;
color.xyz = LargeFunc(color.xyz);
}
else
{
float A = AInt;
float k = kInt;
color.xyz = LargeFunc(color.xyz);
}
If you want I can pm you the actual whole code... Its for my new approach to tonemapping. Originally I wanted to just keep one set of tonemapping parameters for everything, but now I would be interested in splitting them up.
edit: Added the missing ; as pointed out. I did have those included in the actual example
Last edited by Aiyen on 10 Oct 2013, 18:11, edited 1 time in total.
-
Offline
- *blah-blah-blah maniac*
- Posts: 3137
- Joined: 27 Jan 2012, 13:42
Re: --JawZ-- ENB resources for Skyrim, updated 09/01
I believe you're simply missing semicolons (;):
if(EinteriorFactor = 0.0)
{
float A = AExt;
float k = kExt;
color.xyz = LargeFunc(color.xyz)
}
else
{
float A = AInt;
float k = kInt;
color.xyz = LargeFunc(color.xyz)
}
-
Offline
- *sensei*
- Posts: 373
- Joined: 07 Mar 2013, 10:14
Re: --JawZ-- ENB resources for Skyrim, updated 09/01
Yeah I forgot to put them in there in the code example. Thanks for pointing that out! I do have them in the actual code.
It is always the first thing I check when the file wont load....
It is always the first thing I check when the file wont load....
-
Offline
- *blah-blah-blah maniac*
- Posts: 1938
- Joined: 05 Mar 2012, 02:08
-
Offline
- *blah-blah-blah maniac*
- Posts: 506
- Joined: 02 Aug 2013, 23:06
- Location: New Hampshire, US
Re: --JawZ-- ENB resources for Skyrim, updated 09/01
I would like to test both of those out if you want to share the PNG files. Thanks! WGD--JawZ-- wrote:Anyone interested in enblens textures as I'm working on creating a couple?
_________________
Intel Core i9-9900K CPU @ 3.6 GHz // GeForce RTX 2080 Ti VRAM 11GB // Win10 64 and 64GB Ram // Monitor 2560x1440@144
Intel Core i9-9900K CPU @ 3.6 GHz // GeForce RTX 2080 Ti VRAM 11GB // Win10 64 and 64GB Ram // Monitor 2560x1440@144
-
Offline
- *blah-blah-blah maniac*
- Posts: 618
- Joined: 18 Jul 2013, 13:08
- Location: UK
Re: --JawZ-- ENB resources for Skyrim, updated 09/01
Wow JawZ these are really good, converted file 3 to PNG and downsampled to 2k - looks really good in game, complements Kyo's sunsprite shaders beautifully
-
Offline
- *blah-blah-blah maniac*
- Posts: 1938
- Joined: 05 Mar 2012, 02:08
-
Offline
- *blah-blah-blah maniac*
- Posts: 618
- Joined: 18 Jul 2013, 13:08
- Location: UK
Re: --JawZ-- ENB resources for Skyrim, updated 09/01
Hi JawZ
In game with the 2nd lens image from your 1st post, downsampled to 2k, effect exaggerated a bit for sake of screenshot:
(Settings need tweaking to get the right balance in-game.)
Also using Kyo's sunsprite effects
In game with the 2nd lens image from your 1st post, downsampled to 2k, effect exaggerated a bit for sake of screenshot:
(Settings need tweaking to get the right balance in-game.)
Also using Kyo's sunsprite effects