GTA 5 0.351

[lomerta]

thing is everything else is working properly (ao and skylighting, external shaders too), except MSAA.

it seems to remove game msaa but no apply enb one

[ENBSeries]

robi29
Tested the following code in Skyrim SE and it do work.

Code: Select all

	ENBParameter parameterVector;
	parameterVector.Type = ENBParam_VECTOR3;
	parameterVector.Size = ENBParameterTypeToSize(parameterVector.Type);
	float	xxx[3];
	xxx[0]=5.0;
	xxx[1]=0.0;
	xxx[2]=0.0;
	memcpy(parameterVector.Data, &xxx, parameterVector.Size);
	ENBSetParameter(NULL, "ENBEFFECT.FX", "Example xxx", &parameterVector);

Code: Select all

float3	ExampleColor
<
	string UIName = "Example xxx";
	string UIWidget = "vector";
> = {0.0, 1.0, 0.0};

It do not work, if you use low case for shader name and if some callback functions lock processing, as i mentioned in enbseries.h:

Return FALSE if called outside of callback function to protect against graphical artifacts and crashes.

So maybe you did something in wrong order?

lomerta
Man, use photoshop to compare images, there is msaa on both of them.

[robi29]

Ok, thanks. I'll check it.

[robi29]

What a stupidity from my side, I used a structure of floats and it didn't work, but I tried your code with array of floats and works... Anyway, thanks for your effort. You are the best!

[lomerta]

ok I'm out of ideas with the MSAA thing... thank you anyway for trying to help

I have one last question to bother you with, I tried kingeric SMAA postpass and is working great (not enough AA for me but well is SMAA..) I searched for KeyReadConfig but can't find it, so how to recompile shaders without getting out of the game?

also if you don't plan to fix framescaling then will you add downsampling? I know the one in gta4 was very inefficient, but is better than nothing.

[ENBSeries]

lomerta
Shaders are recompiled when pressing Apply button as i remember. About frame scaling and other things, i think i'm done with gta5 modding, its wasting of my time with almost no users.

[random23]

Not sure if i should report it or not, but SelfIntersecting mode can produce a lot of horizontal lines that are visible on the roads, and there is also one dark line that always present at the top of the screen: https://imgur.com/a/JKAPbPi

[ENBSeries]

You have too low sampling range for too high quality of ao. As result, samples are used from same pixels sometime and precision of depth buffer is not enough to produce errors free result. Also size scale and texture source scale in new versions of the mod must be certain values to reduce bugs, because for performance reasons the scaling multiple of 2 is done in the mod, so if you have resolution like 1920*1080 it's okay to have 1.0 or 0.5 scaling or something else which divide by 2. But 1440*810 and scaling 0.5 is bad, it gives 810*0.5/2=202.5.

[random23]

Thanks!

[markimoo0714]

Any chance of adding motion blur or per object motion blur? Because the game default motion blur isn't that good.